Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: more pcolor fixes #16504

Merged
merged 1 commit into from Mar 9, 2020
Merged

DOC: more pcolor fixes #16504

merged 1 commit into from Mar 9, 2020

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Feb 14, 2020

PR Summary

Closes #16493

Note I've removed a bunch of "user_demo" examples. I made those back when I made the original tutorials largely because I thought I was supposed to, but I think we want to not duplicate tutorials and examples, so I have removed them.

From #16493, These remaining files are meant to have warnings emitted:

  • matplotlib/examples/images_contours_and_fields/pcolormesh_grids.py:66
  • matplotlib/examples/images_contours_and_fields/pcolormesh_levels.py:67

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v3.3.0 milestone Feb 14, 2020
@anntzer
Copy link
Contributor

anntzer commented Feb 21, 2020

Perhaps just set the rcParam instead?
Also needs a rebase.

@jklymak
Copy link
Member Author

jklymak commented Feb 21, 2020

I don't think there is anything wrong with being explicit here, even if we plan to change the default. I am not a particular fan of rcParams in examples because the user doesn't know what the rcParam value is.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with being explicit but the examples here are more about different normalizations, not about edge/shading behavior, so I think they slightly distract on the main message. OTOH I won't insist on the change either.
Waiting for CI.

@QuLogic
Copy link
Member

QuLogic commented Mar 7, 2020

Unfortunately needs a rebase again.

@jklymak
Copy link
Member Author

jklymak commented Mar 9, 2020

... rebased

@QuLogic QuLogic merged commit 1b8ede6 into matplotlib:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example/tutorials warn due to new pcolormesh shading
3 participants