Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup imports #16540

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Cleanup imports #16540

merged 1 commit into from
Feb 18, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

Do not explicitly import single classes that are rarely used if the respective module is imported anyway. Use module.Class instead.

@timhoffm timhoffm added this to the v3.3.0 milestone Feb 16, 2020
NelleV
NelleV approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Side note: some of those changes actually break backward compatibility. Eventually, we should try to clean up the namespace of each module to only include functions and classes defined in that module.

@NelleV NelleV merged commit 748e022 into matplotlib:master Feb 18, 2020
@timhoffm timhoffm deleted the clean-import branch February 18, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @NelleV @tacaswell