Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize imshow antialiased tests. #16563

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Parametrize imshow antialiased tests. #16563

merged 1 commit into from
Mar 4, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 20, 2020

Note that one of the old comments "should use nearest" should
actually have been "should use hanning"...

Also not hardcoding rcParams["savefig.dpi"] should be slightly more
robust.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Parametrize imshow antialiased tests.
1965599 
Note that one of the old comments "should use nearest" should
actually have been "should use hanning"...

Also not hardcoding rcParams["savefig.dpi"] should be slightly more
robust.
@anntzer anntzer added this to the v3.3.0 milestone Feb 20, 2020
tacaswell
tacaswell approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependent on CI passing.

Restarted azure win 36, failure looked like file system race conditions.

@timhoffm timhoffm merged commit 30f99f3 into matplotlib:master Mar 4, 2020
@anntzer anntzer deleted the param-aatests branch March 4, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm