Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/CI: also try to run test_user_fonts_win32 on azure #16725

Merged
merged 1 commit into from
Mar 14, 2020

Conversation

tacaswell
Copy link
Member

This will hopefully also help make our code coverage results less
flaky.

I think what is happening is:

  • on master branch azure does upload so we see coverage on the
    pytest.xfail line
  • on PRs azure does not upload so we do not see coverage on the
    pytest.xfail and the measured code coverage goes down 🤦

Hopefully this will always skip this line on CI (as it will actually
run the tests!) which should make our coverage more stable. I suspect
it would be better to move this check into a pytest.mark, but....

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage on that file went down 1.67% for the xfail line, which I guess is what you want?

@QuLogic
Copy link
Member

QuLogic commented Mar 13, 2020

There are some additional coverage differences in the report. I think we might have different/non-installed versions of Ghostscript, plus maybe the setlocale in matplotlib.testing.setup should have coverage ignored.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense...

@anntzer
Copy link
Contributor

anntzer commented Mar 13, 2020

I'll let you pick a milestone and selfmerge.

@QuLogic QuLogic added this to the v3.2.1 milestone Mar 14, 2020
@QuLogic QuLogic merged commit 3909ea2 into matplotlib:master Mar 14, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 14, 2020
QuLogic added a commit that referenced this pull request Mar 14, 2020
…725-on-v3.2.x

Backport PR #16725 on branch v3.2.x (TST/CI: also try to run test_user_fonts_win32 on azure)
@tacaswell tacaswell deleted the ci_run_fonttest_on_azure branch March 15, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants