Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify subgridspec example/tutorial. #17057

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Simplify subgridspec example/tutorial. #17057

merged 1 commit into from
Apr 7, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 7, 2020

  • Use add_gridspec to construct the gridspec and subgridspec to
    construct the subgridspec, saving an import.
  • Use nested loops rather than itertools.product, which is nice but
    not really the point of the tutorial.
  • Index gridspecs with two indices rather than a single flat index,
    again matching "standard" use.
  • Set spine visiibility to the right value directly, rather than first
    toggling them all off and then a few on again.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Simplify subgridspec example/tutorial.
431e993 
- Use add_gridspec to construct the gridspec and subgridspec to
  construct the subgridspec, saving an import.
- Use nested loops rather than itertools.product, which is nice but
  not really the point of the tutorial.
- Index gridspecs with two indices rather than a single flat index,
  again matching "standard" use.
- Set spine visiibility to the right value directly, rather than first
  toggling them all off and then a few on again.
@anntzer anntzer added this to the v3.3.0 milestone Apr 7, 2020
@timhoffm timhoffm merged commit c42d198 into matplotlib:master Apr 7, 2020
@anntzer anntzer deleted the subgrid branch April 7, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @timhoffm