Fix some link redirects in docs #17112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Apr 13, 2020
lib/matplotlib/__init__.py
Outdated
| @@ -444,17 +444,19 @@ def _create_tmp_config_or_cache_dir(): | |||
| def _get_xdg_config_dir(): | |||
| """ | |||
| Return the XDG configuration directory, according to the `XDG | |||
| base directory spec | |||
| <http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html>`_. | |||
| base directory spec: | |||
There was a problem hiding this comment.
Keep the markup; below too.
There was a problem hiding this comment.
It would be too long for our character limit. I didn't want to add a flake8 ignore for that. Since this is a private function, which is not rendered in the docs, I figured it's ok to remove the markup.
There was a problem hiding this comment.
ok but then at least remove the backquote before XDG, so that the thing stays correct markup (even if not rendered.
below too.
timhoffm
force-pushed
the
link-redirects
branch
from
a029985
to
45d005a
Compare
anntzer
reviewed
Apr 13, 2020
| @@ -38,7 +38,7 @@ rendered properly in matplotlib's 2D rendering engine. | |||
| This problem will likely not be solved until OpenGL support is added to all of | |||
| the backends (patches are greatly welcomed). Until then, if you need complex | |||
| 3D scenes, we recommend using | |||
| `MayaVi <http://code.enthought.com/projects/mayavi/documentation.php>`_. | |||
| `MayaVi <https://docs.enthought.com/mayavi/mayavi/>`_. | |||
There was a problem hiding this comment.
you could move this link to out of line
use MayaVi_ ... using MayaVi_.
.. _MayaVi: https://...
to avoid duplicating it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Found via shpinx linkcheck (see #5380). There are more, but I was too lazy to fix all now.
No need to backport because these are just redirects.