Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line2d window extents #17199

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brunobeltran
Copy link
Contributor

@brunobeltran brunobeltran commented Apr 20, 2020

PR Summary

Goes on top of #17198. Only the "latest" commit of the two belongs to this PR.

WIP. Fix Line2D.get_window_extent. Supercedes the discussion in #16607. Still fixes #16606, but also accounts for line joins, caps, etc, and with much less code, thanks to updates to Path.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@brunobeltran brunobeltran force-pushed the line2d-window-extents branch 2 times, most recently from 2d605c6 to 812f938 Compare April 20, 2020 15:06
@brunobeltran brunobeltran mentioned this pull request Jun 22, 2020
6 tasks
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_tightbbox doesn't account for markeredgewidth
2 participants