New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solarized dark custom style sheet #17325
Conversation
Hi can you please provide an example of the new stylesheet and explain why it's worth adopting? |
The solarized palette comes in light and dark flavor. We currently have a solarized light style but not a dark correspondent. It makes sense to add the dark style as well. My concern is that the dark and light style should be the same except for the colors. Currently, there are differences with:
Not sure why the light style is called "Solarize_Light2". That's odd in multiple ways:
|
@@ -0,0 +1,30 @@ | |||
## FIGURE | |||
figure.facecolor : 002b36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use spaces, not tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
I could mirror the current light theme if you believe this is the standard we have to follow, only changing the corresponding colour cycles and palettes. I could wait for your decision on the topic and make the changes accordingly. |
Moreover, find below a small collection of examples of what this theme looks like, obtained by using
|
I think if we have light, we should also have a dark variant, but they should be consistent in what they change. I never understood the naming of our light Solarized theme, and no-one answered when I asked. I think we should add a new one with more consistent name (and whatever consistencies we need with a dark variant) and (soft?-)deprecate the old one. |
If you think the current proposal for the dark theme satisfies the requirements I could create the equivalent for the light version, so that the two mirror each other except for the actual colour palettes. |
This fell off everyone's radar, but I think would be a useful addition... |
I would like to propose a custom style sheet in line with the solarized dark colour palette. The style mirrors the ones already present and is the only addition to this pull request.