Fix drawing zoom rubberband on GTK backends. #17877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
added
Release critical
tacaswell
reviewed
Jul 10, 2020
Just like Qt, the drawing should only be done in the draw (paint) event, so move the rubberband draw there. Also, make it black-and-white like the Qt one. Fixes matplotlib#17773.
tacaswell
approved these changes
Jul 15, 2020
|
Anyone can merge this on green. |
dopplershift
approved these changes
Jul 15, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 15, 2020
jklymak
added a commit
that referenced
this pull request
Jul 15, 2020
…877-on-v3.3.x Backport PR #17877 on branch v3.3.x (Fix drawing zoom rubberband on GTK backends.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Just like Qt, the drawing should only be done in the draw (paint) event, so move the rubberband draw there. Also, make it black-and-white like the Qt one.
Fixes #17773.
PR Checklist