Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added density and combination hatching examples #17921

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Added density and combination hatching examples #17921

merged 2 commits into from
Jul 14, 2020

Conversation

forrestm
Copy link
Contributor

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@forrestm forrestm mentioned this pull request Jul 14, 2020
Closed
@forrestm
Update hatch style reference
6d7bcf4 
Corrected figsize, removed repeated function, and fixed repeated hatches.
@jklymak
Copy link
Member

jklymak commented Jul 14, 2020

This rendered here: https://41228-1385122-gh.circle-artifacts.com/0/doc/build/html/gallery/shapes_and_collections/hatch_style_reference.html#sphx-glr-gallery-shapes-and-collections-hatch-style-reference-py

Looks fine to me.

@jklymak jklymak added this to the v3.4.0 milestone Jul 14, 2020
story645
story645 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge once travis gives the OK

@story645 story645 merged commit b803891 into matplotlib:master Jul 14, 2020
@story645 story645 linked an issue Jul 14, 2020 that may be closed by this pull request
Extend hatch reference #17918
Closed
@forrestm forrestm deleted the Extend-hatch-reference branch July 14, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Extend hatch reference
3 participants
@forrestm @jklymak @story645