Catch Pandas AssertionError on deprecated multidimensional indexing. Closes #18158 #18167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-johnston
changed the title
jklymak
added
third-party integration
Release critical
|
It might be better to narrow the AssertionError catch to the Pandas warning using: ...
try:
ndim = x[:, None].ndim
except AssertionError as exc:
if len(w) > 0:
return np.asanyarray(x)
else:
raise AssertionError(exc) from None
...Do you prefer this approach? |
|
I wasn't concerned about the approach, just that we have to do such a dance to get around it. If we are going to first-class pandas like this, we really need to test their RCs and vice-versa. |
tacaswell
approved these changes
Aug 4, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 4, 2020
…ed multidimensional indexing. Closes matplotlib#18158
|
Thanks @l-johnston ! I think (?) this is your first Matplotlib RP, 🎉 Hopefully we will hear from you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #18158 due to pandas-dev/pandas#35527