Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the return value of Axes.get_navigate_mode. #18173

Merged
merged 1 commit into from Aug 5, 2020
Merged

Fix the return value of Axes.get_navigate_mode. #18173

merged 1 commit into from Aug 5, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 4, 2020

PR Summary

Fixes #18150.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: toolbar labels Aug 4, 2020
@QuLogic QuLogic added this to the v3.3.1 milestone Aug 4, 2020
@timhoffm timhoffm merged commit 0042efd into matplotlib:master Aug 5, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 5, 2020
@timhoffm @meeseeksmachine
Backport PR matplotlib#18173: Fix the return value of Axes.get_naviga…
ff98c22 
…te_mode.
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 5, 2020
Merged
@QuLogic QuLogic deleted the fix-get-navigate-mode branch August 5, 2020 00:09
QuLogic added a commit that referenced this pull request Aug 5, 2020
@QuLogic
Merge pull request #18176 from meeseeksmachine/auto-backport-of-pr-18…
0c3c37d 
…173-on-v3.3.x

Backport PR #18173 on branch v3.3.x (Fix the return value of Axes.get_navigate_mode.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: toolbar
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

Regression in get_navigate_mode() return value
3 participants
@QuLogic @tacaswell @timhoffm