Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use certifi when downloading bundled build requirements. #18225

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 11, 2020

PR Summary

This should fix build on macOS.
cf https://github.com/QuLogic/matplotlib/runs/973372905?check_suite_focus=true vs https://github.com/QuLogic/matplotlib/runs/973391400?check_suite_focus=true

PR Checklist

  • [n/a] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic QuLogic added the Build label Aug 11, 2020
@QuLogic QuLogic added this to the v3.3.1 milestone Aug 11, 2020
@jklymak jklymak merged commit 6a97c97 into matplotlib:master Aug 12, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 12, 2020
jklymak added a commit that referenced this pull request Aug 12, 2020
…225-on-v3.3.x

Backport PR #18225 on branch v3.3.x (Use certifi when downloading bundled build requirements.)
@QuLogic QuLogic deleted the certifi-freetype branch August 12, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants