Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Path.get_extents for empty paths. #18266

Merged
merged 1 commit into from Aug 15, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 15, 2020

PR Summary

Fixes #18254

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.3.2 milestone Aug 15, 2020
@jklymak
Copy link
Member

jklymak commented Aug 15, 2020

This could be fine, but I'm not sure it gives the same result as master does?

@QuLogic
Copy link
Member Author

QuLogic commented Aug 15, 2020

master currently crashes this test, just like the linked issue.

@jklymak
Copy link
Member

jklymak commented Aug 15, 2020

... OK, but on master, the original issue does return a finite extent, whereas I think with this change it will not.

@dopplershift
Copy link
Contributor

@jklymak Did you see @QuLogic 's comment in #18254?

This works in master because we only reverted #17543 for 3.3.x. On master, there are no facecolors because 'none' is an unfilled marker, so the single path optimization is not checked, and then Path.get_extents is not called. The bug is still there, it's just not triggered.

So I think that's why master was working. Unless I'm misunderstanding something here...

@dopplershift
Copy link
Contributor

Mac failures unrelated. Merging...

@dopplershift dopplershift merged commit 591b857 into matplotlib:master Aug 15, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 15, 2020
dopplershift added a commit that referenced this pull request Aug 15, 2020
…266-on-v3.3.x

Backport PR #18266 on branch v3.3.x (Fix Path.get_extents for empty paths.)
@QuLogic QuLogic deleted the fix-empty-path-extent branch August 17, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scatter(..., marker='') raises on drawing with mpl3.3.1
3 participants