Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEANUP: validate join/cap style centrally #18542

Merged
merged 1 commit into from Sep 22, 2020

Conversation

brunobeltran
Copy link
Contributor

PR Summary

Simple change. There was a straggling spot in lines.py that still did its own validation of joinstyle/capstyle instead of using rcsetup.validate_joinstyle/_capstyle.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be that we want validators in a dedicated central place other than rcsetup in the future. Validators being in rcsetup is just the result of recsetup historically being the only place using validators.

@QuLogic QuLogic added this to the v3.4.0 milestone Sep 22, 2020
@QuLogic QuLogic merged commit 3f92f43 into matplotlib:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants