Improve warning message for missing font family specified via alias. #18927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Nov 10, 2020
QuLogic
reviewed
Nov 11, 2020
lib/matplotlib/font_manager.py
Outdated
| if family in font_family_aliases: | ||
| _log.warning( | ||
| "findfont: Font family %r not found because none " | ||
| "of the following families were found: %s", |
There was a problem hiding this comment.
These are all families (https://developer.mozilla.org/en-US/docs/Web/CSS/font-family), a "font" includes not only the family but also the size, etc. I did slightly reword the message to refer to (e.g.) "sans" as a "generic family", though (again following CSS terminology).
See example of warning message in the test.
QuLogic
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See example of warning message in the test.
Closes #18926.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).