Simplify contour_label_demo. #18976
Merged
Simplify contour_label_demo. #18976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Nov 19, 2020
| # Make contour labels using creative float classes | ||
| # Follows suggestion of Manuel Metz | ||
| # Make contour labels wuth custom level formatters. | ||
| # (From a suggestion of Manuel Metz.) |
There was a problem hiding this comment.
I assume this reference concerned the custom float, so it can be left out. With the formatter we are using standard Matplotlib constructs, that do not need and Schwule not have attribution.
Using a custom float subclass is very overkill, one can simply use a custom formatter.
timhoffm
approved these changes
Nov 19, 2020
|
😕 @jonnyhtw (op) had wanted to work on this, but if he thinks this is still unclear a PR to clarify would still be welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a custom float subclass is very overkill, one can simply use a
custom formatter.
xref #18974.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).