Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Specifying Colors tutorial format & arrange #19093

Merged
merged 7 commits into from
Dec 29, 2020
Merged

DOCS: Specifying Colors tutorial format & arrange #19093

merged 7 commits into from
Dec 29, 2020

Conversation

jeromefv
Copy link
Contributor

@jeromefv jeromefv commented Dec 11, 2020 •
edited
Loading

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

story645
story645 requested changes Dec 11, 2020
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table makes me very happy. I'm finding the RGB section a bit hard to follow but I don't know if my suggestions are in scope for this PR

tutorials/colors/colors.py Outdated Show resolved Hide resolved
tutorials/colors/colors.py Outdated Show resolved Hide resolved
tacaswell
tacaswell previously requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with all of the changes except for the alpha-related changes.

Anyone can clear this review after changes to the text related to alpha.

@tacaswell tacaswell modified the milestones: v3.3.4, v3.4.0 Dec 14, 2020
story645
story645 approved these changes Dec 17, 2020
View reviewed changes
tutorials/colors/colors.py Outdated Show resolved Hide resolved
QuLogic
QuLogic reviewed Dec 22, 2020
View reviewed changes
tutorials/colors/colors.py Outdated Show resolved Hide resolved
@story645 story645 self-requested a review December 22, 2020 22:13
timhoffm
timhoffm reviewed Dec 23, 2020
View reviewed changes
tutorials/colors/colors.py Show resolved Hide resolved
tutorials/colors/colors.py Outdated Show resolved Hide resolved
tutorials/colors/colors.py Show resolved Hide resolved
tutorials/colors/colors.py Show resolved Hide resolved
tutorials/colors/colors.py Outdated Show resolved Hide resolved
tutorials/colors/colors.py Outdated Show resolved Hide resolved
tutorials/colors/colors.py Outdated Show resolved Hide resolved
jeromefv
jeromefv commented Dec 24, 2020
View reviewed changes
Copy link
Contributor Author

@jeromefv jeromefv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to start my own review.

tutorials/colors/colors.py Outdated Show resolved Hide resolved
dstansby
dstansby approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome 🥳

timhoffm
timhoffm approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a significant improvement! 👍 Let's get it in. One can always polish up more, but that can be done another time. 😄

@timhoffm timhoffm merged commit c6d2581 into matplotlib:master Dec 29, 2020
@timhoffm timhoffm mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

@QuLogic QuLogic QuLogic left review comments

@jklymak jklymak jklymak left review comments

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

@story645 story645 Awaiting requested review from story645

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jeromefv @tacaswell @QuLogic @story645 @jklymak @timhoffm @dstansby