Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed part of Issue - #19100, changed documentation for axisartist #19192

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Fixed part of Issue - #19100, changed documentation for axisartist #19192

merged 1 commit into from
Dec 29, 2020

Conversation

aflah02
Copy link
Contributor

@aflah02 aflah02 commented Dec 29, 2020

Issue - The axisartist.axis_artist docs page has a typo: ax.axis["bottom"].major_ticks.set_ticks_out(True) should be ax.axis["bottom"].major_ticks.set_tick_out(True) (remove 's' after 'tick' in 'set_tick_out')
Fixed it by removing the s
closes #19100

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Issue - The axisartist.axis_artist docs page has a typo: ax.axis["bottom"].major_ticks.set_ticks_out(True) should be ax.axis["bottom"].major_ticks.set_tick_out(True) (remove 's' after 'tick' in 'set_tick_out')
Fixed it by removing the s
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a little sad that this is actually set_tick_out instead of set_ticks_out, but axis grid is not the most well-reviewed part of the code base.

@jklymak jklymak added this to the v3.4.0 milestone Dec 29, 2020
@jklymak jklymak merged commit 195030b into matplotlib:master Dec 29, 2020
@jklymak
Copy link
Member

jklymak commented Dec 29, 2020

Thanks @aflah02

@aflah02
Copy link
Contributor Author

aflah02 commented Dec 29, 2020

you're welcome @jklymak

@aflah02 aflah02 deleted the docupdate branch December 29, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axisartist documentation missing for classes and functions, and has typos
2 participants