Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update homebrew on GitHub Actions #19266

Merged
merged 2 commits into from
Jan 9, 2021
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 9, 2021

PR Summary

This leaves us at the mercy of whenever Actions updates the formula database in the image, but also prevents it from trying to update stuff in the image that we don't want it to update.

Also, disable fail-fast.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • [n/a] Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This leaves us at the mercy of whenever Actions updates the formula
database, but also prevents it from trying to update stuff in the image
that we don't want it to update.
@QuLogic QuLogic added this to the v3.3.4 milestone Jan 9, 2021
@jklymak jklymak merged commit 4e4410d into matplotlib:master Jan 9, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 9, 2021
@QuLogic QuLogic deleted the fix-ci branch January 9, 2021 22:24
timhoffm added a commit that referenced this pull request Jan 9, 2021
…266-on-v3.3.x

Backport PR #19266 on branch v3.3.x (Don't update homebrew on GitHub Actions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants