Workaround for Python 3 with pyparsing <= 2.0.0 #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In #1788, @juliantaylor suggested adding a test for the bug, rather than a strict version check. I thought it actually better to have a workaround, which is to turn off packrat parsing... It would be difficult to test for the case and then respond accordingly, since there is no function to disable packrat parsing once it is enabled. I think this at least allows people who fall in the hole of being on Python 3 but who want to install everything from dependencies to move forward with something that at least works. |
mdboom
added a commit
that referenced
this pull request
May 13, 2013
Workaround for Python 3 with pyparsing <= 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning off packrat parsing will avoid a bug in pyparsing <= 2.0.0, however it is much slower.
http://pyparsing.svn.sourceforge.net/viewvc/pyparsing/src/pyparsing_py3.py?r1=219&r2=218&pathrev=219
This is a follow on to the discussion in #1788