Create box3d example #19363

iuryt · 2021-01-26T12:48:32Z

Suggestion from #19310

PR Summary

This pull request adds a new example for the 3D plots.
I am not sure how to check all steps from the Checklist, but it is simply adding a new example.

Origin of this suggestion: #19310

PR Checklist

Has pytest style unit tests (and pytest passes).
Is Flake 8 compliant (run flake8 on changed files to check).
New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs should build without error).
Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

github-actions

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

iuryt

I have implemented all suggested changes.

Missing whitespaces
Replace single by double quotes

iuryt

I have incorporated the latest changes.

iuryt

Incorporated pflakes suggestions

iuryt

Incorporate pflakes suggestions

iuryt

Incorporate pflakes suggestions

iuryt

Incorporated PyLint suggestions.

iuryt · 2021-01-26T22:20:41Z

Hi @jklymak
This is my first pull request to matplotlib.
I don't know what circleci stands for.
What should I do?

jklymak · 2021-01-26T22:40:30Z

Circle CI builds the docs for you. If it is failing. you likely have a syntax error or a reference that doesn't resolve. Have a look at the log output (click on Details), and do a case-sensitive search on WARNING usually will help you find it.

QuLogic · 2021-01-26T22:49:46Z

We do not have xarray installed for docs builds, and I'm not sure we want to. Can this example be written without it?

jklymak · 2021-01-26T22:58:54Z

Yeah, definitely no xarray (as much as I love xarray)

iuryt · 2021-01-27T14:56:03Z

Ok! I will rewrite it without xarray.

iuryt

Replaced Xarray by NumPy

iuryt

Incorporate flake8 suggestions

iuryt

Breaking long lines.

iuryt · 2021-01-27T18:11:28Z

Hi @QuLogic and @jklymak ,

I have updated the script using NumPy instead of Xarray and it still fails on CircleCI.

jklymak

Great! Now you have a bunch of flake8 errors though that need to be fixed. Sorry, they are annoying, but help keep the code semi-consistent....

iuryt · 2021-01-27T19:28:12Z

@jklymak
Im sorry, but here it is saying that the flake8 test was successful.
Does it do another flake8 test inside circleci?

jklymak · 2021-01-27T20:20:14Z

oops, it seems fine now. Thanks.

QuLogic · 2021-01-28T04:52:41Z

The example is still failing to run... Does it work for you?

iuryt · 2021-01-28T13:56:44Z

If I run here, this is the output:

Matplotlib version: '3.2.2'
NumPy version: '1.16.4'

jklymak · 2021-01-28T15:29:07Z

Hmmm, well unfortunately it has to pass on CI. Click through the links under "Checks" and you will see how this is failing.

QuLogic · 2021-01-29T03:39:45Z

The failure appears to be a regression. It is partially from eb76378, which causes the YZ plane to break, and partially from 4428da6, which breaks it completely.

Unfortunately, 3.3.4 was just tagged, so it won't be fixed there, but I think we should fix this for 3.4.0.

jklymak · 2021-02-01T03:11:17Z

The aspect ratio has changed, but this now works with #19399

QuLogic · 2021-02-03T20:27:50Z

If you rebase on latest master, this should now work again on CI.

iuryt · 2021-02-04T21:17:25Z

It looks like it failed for Tests / Python 3.8 on ubuntu-16.04 (pull_request).

timhoffm

Thanks for the PR!

Generally, aim at making the example as small and concise as possible, both the description and the code. This will help people to understand it and get the relevant information and concepts used.

examples/mplot3d/box3d.py

Change 'da' to 'data' Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Simplify definition for contourf key args Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Compacting code Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Simplify the title of the tutorial Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Concise documentation Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Remove credits

Replace da for data

iuryt

Replace 'da' for 'data'

examples/mplot3d/box3d.py

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

iuryt · 2021-04-23T19:13:09Z

@QuLogic
Sorry for the late response to this matter.
Let me know if this works.

examples/mplot3d/box3d.py

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

QuLogic · 2021-05-03T23:52:06Z

Thanks @iuryt! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

iuryt · 2021-05-03T23:58:47Z

Thanks @QuLogic !
I was a long journey for a simple contribution, but I have learned a lot.
Hope I have other contributions to community.

github-actions bot reviewed Jan 26, 2021

View reviewed changes

iuryt commented Jan 26, 2021

View reviewed changes

iuryt commented Jan 27, 2021

View reviewed changes

jklymak reviewed Jan 27, 2021

View reviewed changes

QuLogic added this to the v3.4.0 milestone Jan 29, 2021

QuLogic added the Documentation label Jan 29, 2021

QuLogic changed the title ~~Create box3d.py~~ Create box3d example Jan 29, 2021

QuLogic mentioned this pull request Jan 29, 2021

Fix empty Poly3DCollections #19399

Merged

3 tasks

QuLogic added the status: needs rebase label Feb 3, 2021

jklymak modified the milestones: v3.4.1, v3.4-doc Feb 4, 2021

timhoffm reviewed Feb 4, 2021

View reviewed changes

iuryt and others added 7 commits February 4, 2021 18:34

Update examples/mplot3d/box3d.py

e4b80fd

Change 'da' to 'data' Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Update examples/mplot3d/box3d.py

adeaa0d

Simplify definition for contourf key args Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Update examples/mplot3d/box3d.py

34a4e98

Compacting code Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Update examples/mplot3d/box3d.py

1d6984e

Simplify the title of the tutorial Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Update examples/mplot3d/box3d.py

1c6f970

Concise documentation Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Update box3d.py

3db0dd0

Remove credits

Update box3d.py

24017e4

Replace da for data

iuryt commented Feb 4, 2021

View reviewed changes

examples/mplot3d/box3d.py Outdated Show resolved Hide resolved

QuLogic reviewed Feb 9, 2021

View reviewed changes

examples/mplot3d/box3d.py Outdated Show resolved Hide resolved

examples/mplot3d/box3d.py Outdated Show resolved Hide resolved

QuLogic added status: needs revision and removed status: needs rebase labels Feb 18, 2021

iuryt and others added 2 commits April 23, 2021 14:18

Update examples/mplot3d/box3d.py

68597ec

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

Remove '\n' from xlabel and ylabel

cf67e4f

QuLogic reviewed Apr 23, 2021

View reviewed changes

examples/mplot3d/box3d.py Show resolved Hide resolved

Update box3d.py

c88ed51

QuLogic reviewed Apr 27, 2021

View reviewed changes

examples/mplot3d/box3d.py Outdated Show resolved Hide resolved

Update examples/mplot3d/box3d.py

6f5f355

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

QuLogic approved these changes May 3, 2021

View reviewed changes

QuLogic removed the status: needs revision label May 3, 2021

QuLogic modified the milestones: v3.4-doc, v3.5.0 May 3, 2021

QuLogic merged commit f6790c0 into matplotlib:master May 3, 2021

rcomer mentioned this pull request Jun 16, 2023

Implement pyplot.box3d() for Axes3D #19310

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create box3d example #19363

Create box3d example #19363

iuryt commented Jan 26, 2021

github-actions bot left a comment

iuryt left a comment

iuryt left a comment

iuryt left a comment

iuryt left a comment

iuryt left a comment

iuryt left a comment

iuryt commented Jan 26, 2021

jklymak commented Jan 26, 2021

QuLogic commented Jan 26, 2021

jklymak commented Jan 26, 2021

iuryt commented Jan 27, 2021

iuryt left a comment

iuryt left a comment

iuryt left a comment

iuryt commented Jan 27, 2021

jklymak left a comment

iuryt commented Jan 27, 2021

jklymak commented Jan 27, 2021

QuLogic commented Jan 28, 2021 •

edited

Loading

iuryt commented Jan 28, 2021

jklymak commented Jan 28, 2021

QuLogic commented Jan 29, 2021

jklymak commented Feb 1, 2021

QuLogic commented Feb 3, 2021

iuryt commented Feb 4, 2021

timhoffm left a comment

iuryt left a comment

iuryt commented Apr 23, 2021

QuLogic commented May 3, 2021

iuryt commented May 3, 2021

Create box3d example #19363

Create box3d example #19363

Conversation

iuryt commented Jan 26, 2021

PR Summary

PR Checklist

github-actions bot left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt commented Jan 26, 2021

jklymak commented Jan 26, 2021

QuLogic commented Jan 26, 2021

jklymak commented Jan 26, 2021

iuryt commented Jan 27, 2021

iuryt left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt commented Jan 27, 2021

jklymak left a comment

Choose a reason for hiding this comment

iuryt commented Jan 27, 2021

jklymak commented Jan 27, 2021

QuLogic commented Jan 28, 2021 • edited Loading

iuryt commented Jan 28, 2021

jklymak commented Jan 28, 2021

QuLogic commented Jan 29, 2021

jklymak commented Feb 1, 2021

QuLogic commented Feb 3, 2021

iuryt commented Feb 4, 2021

timhoffm left a comment

Choose a reason for hiding this comment

iuryt left a comment

Choose a reason for hiding this comment

iuryt commented Apr 23, 2021

QuLogic commented May 3, 2021

iuryt commented May 3, 2021

QuLogic commented Jan 28, 2021 •

edited

Loading