Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: DOCS: fix slash for windows in conf.py #19418

Merged
merged 1 commit into from Feb 1, 2021

Conversation

brunobeltran
Copy link
Contributor

@brunobeltran brunobeltran commented Feb 1, 2021

PR Summary

Single line fix to remove a hard-coded slash that was preventing the docs from building on windows in Anaconda.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

doc/conf.py Show resolved Hide resolved
@tacaswell tacaswell added this to the v3.4.0 milestone Feb 1, 2021
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on green.

@brunobeltran
Copy link
Contributor Author

Some extension seems to have changed under us? Doc build works locally, but is failing on CI.

@jklymak
Copy link
Member

jklymak commented Feb 1, 2021

rebase - fix is on master

@jklymak jklymak merged commit 5713e77 into matplotlib:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants