Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify _redo_transform_rel_fig. #20023

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Simplify _redo_transform_rel_fig. #20023

merged 1 commit into from
Apr 20, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 20, 2021

  • width_ratios and height_ratios are never None (None gets normalized to
    [1, 1, ...] in the setters).
  • We don't need to separately handle the is_first_row()/is_last_col()
    cases (the sums will evaluate to 0/1 as needed).
  • Naming the width/height dx/dy makes everything line up neatly.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

- width_ratios and height_ratios are never None (None gets normalized to
  [1, 1, ...] in the setters).
- We don't need to separately handle the `is_first_row()/is_last_col()`
  cases (the sums will evaluate to 0/1 as needed).
- Naming the width/height dx/dy makes everything line up neatly.
@jklymak jklymak merged commit 440a8e0 into matplotlib:master Apr 20, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Apr 20, 2021
@anntzer anntzer deleted the rtrf branch April 20, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants