-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove check for sizes=0 in legend_elements #20269
Draft
Illviljan
wants to merge
23
commits into
matplotlib:main
Choose a base branch
from
Illviljan:Illviljan-legend_elements_remove_zero_sizes
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove check for sizes=0 in legend_elements #20269
Illviljan
wants to merge
23
commits into
matplotlib:main
from
Illviljan:Illviljan-legend_elements_remove_zero_sizes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambiguous variable name 'l'
Remove repeated ifs, duplicate variables, multiple min/max calls.
no need to for set_locs in for loop
Removing 0 sized markers in the legend is a little weird. Feels more like a user error to add 0 sized markers to the plot. Maybe it should've started to error when adding that to the scatter? 0 in sizes broke the tests, as well as changing seeds. Still not perfect because num=9 isn't always respected.
Add and improve some comments. Rename variables for better readabillity. Use LinearLocator for to get evenly distributed indexes. It's more inline with the numerics and allows more flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This check removed legend labels that have sizes close to 0 in the legend. So now that I removed it, everything that's in the plot will always be shown in the legend labels as well which makes sense to me and is easy to test.
s=0
values are still in the plot being calculated with and slowing the down the plot. So usings=0
to remove "bad" points from plot and legend seems like a bad habit that doesn't need encouragement. If you want to filter it should've been done before creating the scatter like:One could also argue that we are just fixing a bug because:
np.isclose()
parameters, so maybe there's some user out there working with small numbers and needs to change the parameters. So it's better to just let the user filter out points close to 0 before plotting the data.PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).