Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch version scheme to release-branch-semver. #20369

Merged
merged 1 commit into from Jun 7, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 4, 2021

PR Summary

While setuptools-scm does not yet support our branch naming scheme for release branches, it will soon [1]. And we won't have to worry about that until we actually branch for 3.5.0, since the v3.4.x branch doesn't use it.

[1] pypa/setuptools_scm#573

Fixes #19419.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

While setuptools-scm does not yet support our branch naming scheme for
release branches, it will soon [1]. And we won't have to worry about
that until we actually branch for 3.5.0, since the v3.4.x branch doesn't
use it.

[1] pypa/setuptools_scm#573
@QuLogic QuLogic added the Build label Jun 4, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Jun 4, 2021
@tacaswell
Copy link
Member

From the logs:

Successfully installed matplotlib-3.5.0.dev984+g483e21154

@dstansby dstansby merged commit 63261cc into matplotlib:master Jun 7, 2021
@QuLogic QuLogic deleted the setuptools-semver branch June 7, 2021 19:58
@ericpre ericpre mentioned this pull request Aug 25, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev version hard to check
3 participants