New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change legend guide to object oriented approach #20792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if one of the plt examples should be left in as a resource but otherwise is awesome.
84a7c7a
to
9d821e5
Compare
9d821e5
to
078a87e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally agree w/ you about adding in something on location, possibly as an expansion of https://62747-1385122-gh.circle-artifacts.com/0/doc/build/html/tutorials/intermediate/legend_guide.html#legend-location & maybe using the cheatsheet as inspiration?
https://github.com/matplotlib/cheatsheets/blob/master/cheatsheets-2.png
078a87e
to
5cb4dcf
Compare
I was thinking perhaps something like creating a 3x3 (or 2 x2 w.e) |
I think it's a good idea to leave it to another issue since that's gonna be a bigger change to the guide content so folks might have more opinions. |
5cb4dcf
to
7f7aa64
Compare
PR Summary
Addresses #20754 to change legend guide from all
pyplot
interface to theax
objected oriented approachPR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).