Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Rename callbacksSM to callbacks #20799

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

greglucas
Copy link
Contributor

PR Summary

This makes the code more consistent throughout with objects having a callbacks attribute, rather than associating a name with them on the end and using camelCase.

First noticed by @timhoffm in #19553 (comment)

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This makes the code more consistent throughout with objects
having a `callbacks` attribute, rather than associating a name
with them on the end.
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 9, 2021
@QuLogic QuLogic merged commit d77783b into matplotlib:master Aug 9, 2021
@greglucas greglucas deleted the rename-callbacksSM branch August 9, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants