Fix ToolManager + TextBox support. #20997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try running e.g. examples/widgets/textbox.py together with `rcParams["toolbar"] = "toolmanager"`. Before this fix, clicking on the TextBox would result in "TypeError: push() takes 2 positional arguments but 3 were given".
dstansby
approved these changes
Sep 4, 2021
| @pytest.mark.parametrize("toolbar", ["none", "toolbar2", "toolmanager"]) | ||
| def test_TextBox(toolbar): | ||
| # Avoid "toolmanager is provisional" warning. | ||
| dict.__setitem__(plt.rcParams, "toolbar", toolbar) |
There was a problem hiding this comment.
Out of interest, why this and not plt.rcParams['toolbar'] = toolbar?
There was a problem hiding this comment.
Because rcParams["toolbar"] = "toolmanager" emits a "toolmanager is provisional API" warning. (Sure, you can play with warnings filters to suppress that, but ugh...)
timhoffm
approved these changes
Sep 4, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 4, 2021
dstansby
added a commit
that referenced
this pull request
Sep 5, 2021
…997-on-v3.5.x Backport PR #20997 on branch v3.5.x (Fix ToolManager + TextBox support.)
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fix ToolManager + TextBox support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try running e.g. examples/widgets/textbox.py together with
rcParams["toolbar"] = "toolmanager". Before this fix, clicking on theTextBox would result in "TypeError: push() takes 2 positional arguments
but 3 were given".
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).