Fix very-edge case in csd(), plus small additional cleanups. #21191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Sep 27, 2021
QuLogic
reviewed
Sep 27, 2021
QuLogic
reviewed
Sep 27, 2021
Previously, `csd([0, 0], [0, 0])` would fail with a ZeroDivisionError when computing yticks. Fix that by copying the logic from psd, and streamlining it in both places. Also fix an unformatted exception message in specgram.
QuLogic
approved these changes
Sep 28, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 28, 2021
… additional cleanups.
QuLogic
added a commit
that referenced
this pull request
Sep 28, 2021
…191-on-v3.5.x Backport PR #21191 on branch v3.5.x (Fix very-edge case in csd(), plus small additional cleanups.)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Fix very-edge case in csd(), plus small additional cleanups.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fix very-edge case in csd(), plus small additional cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
csd([0, 0], [0, 0])would fail with a ZeroDivisionErrorwhen computing yticks. Fix that by copying the logic from psd, and
streamlining it in both places. Also fix an unformatted exception
message in specgram.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).