Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #21833: Enforce backport conditions on v*-doc branches #22221

Conversation

tacaswell
Copy link
Member

Merge pull request #21833 from QuLogic/clean-doc-backports

CI: Enforce backport conditions on v*-doc branches

…ranches

Merge pull request matplotlib#21833 from QuLogic/clean-doc-backports

CI: Enforce backport conditions on v*-doc branches
@tacaswell tacaswell added this to the v3.5-doc milestone Jan 12, 2022
@timhoffm timhoffm closed this Jan 17, 2022
@timhoffm timhoffm reopened this Jan 17, 2022
@tacaswell
Copy link
Member Author

This is failing on the changes in float results due to the SIMD instructions that numpy now ships with in their wheel. We need to do one of:

  • backport the tolerance increase
  • pin back numpy
  • use the envs variables to turn off the SIMD instructions
  • turn off everything but doc building and publishing on these branchs

I lean towards the last option (turn off tests on the docs branch).

@QuLogic
Copy link
Member

QuLogic commented Jan 18, 2022

They're already supposed to be off, but this only covers direct pushes, and not PR targets.

@QuLogic
Copy link
Member

QuLogic commented Jan 18, 2022

See #22256

@tacaswell tacaswell closed this Jan 18, 2022
@tacaswell tacaswell reopened this Jan 18, 2022
@QuLogic QuLogic closed this Jan 19, 2022
@QuLogic QuLogic reopened this Jan 19, 2022
@QuLogic
Copy link
Member

QuLogic commented Jan 19, 2022

Ah, even though it appears that test were run here, they are the original ones from the last time. Since they didn't run again, the old statuses were not removed.

@QuLogic QuLogic merged commit feb68c7 into matplotlib:v3.5.1-doc Jan 19, 2022
@tacaswell tacaswell deleted the auto-backport-of-pr-21833-on-v3.5.1-doc branch January 19, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants