Add set_cursor method to FigureCanvasTk #22294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Since 3.5,
NavigationToolbar2.set_cursor
is deprecated in favour ofFigureCanvasBase.set_cursor
. This adds theset_cursor
method toFigureCanvasTk
to make the cursor respond to move/zoom modes again, and removes it fromNavigationToolbar2Tk
as the parentNavigationToolbar2.set_cursor
just callsFigureCanvasBase.set_cursor
now.I'm setting the cursor for the canvas specifically rather than for the canvas's master as before, as the cursor change should only ever affect the canvas (and not the toolbar, or any sibling widgets if dealing with an embedded plot).
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).