Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade requirement to pyparsing 2.0.1 #2240

Merged

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jul 23, 2013

The newly released pyparsing 2.0.1 fixes a number of problems with supporting Python 2.x and 3.x at the same time. Unfortunately, I think the ship has sailed to get this in for 1.3.0, but for 1.3.1 we should be able to do this.

http://code.activestate.com/lists/python-list/647675/

@jenshnielsen
Copy link
Member

Shouldn't the install test al least drop the check for pyparsing < 2.0.0 in get_install_version() in setupext.py on python 2.x since pyparsing 2.0.1 now works with python 2.6 and 2.7?

@mdboom
Copy link
Member Author

mdboom commented Jul 23, 2013

@jenshnielsen: That's a good point. See attached. We should be able to squeak this into 1.3.0 final. However, I will put of solving the deprecation warnings, since we need to remain compatible with pyparsing < 2.0.0

@jenshnielsen
Copy link
Member

Thanks. I have tested rc5 with pyparsing 2.0.1 on both python 27.5 and 3.3.2 and all tests pass.

I agree that the solution to the deprecation warnings should wait until post 1.3.0

mdboom added a commit that referenced this pull request Jul 23, 2013
…ment

Upgrade requirement to pyparsing 2.0.1
@mdboom mdboom merged commit 083c788 into matplotlib:v1.3.x Jul 23, 2013
This was referenced Aug 2, 2013
@mdboom mdboom deleted the update-pyparsing-version-requirement branch August 7, 2014 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants