Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid indiscriminate glob-remove in xpdf_distill. #22423

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 7, 2022

Even though it is unlikely that the glob-remove will hit any
non-temporary files (because tmpfile will typically be, well, a
temporary file with a non-guessable filename), it still looks not so
nice and can easily be replaced by using controlled temporary filenames
and using TemporaryDirectory for auto-cleanup.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Even though it is unlikely that the glob-remove will hit any
non-temporary files (because tmpfile will typically be, well, a
temporary file with a non-guessable filename), it still looks not so
nice and can easily be replaced by using controlled temporary filenames
and using TemporaryDirectory for auto-cleanup.
@QuLogic QuLogic merged commit 1178983 into matplotlib:main Feb 8, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone Feb 8, 2022
@anntzer anntzer deleted the xpdf branch February 8, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants