Fix incorrect deprecation warning #22719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Mar 28, 2022
|
I think we already have tests of these warnings, 👍🏻 on adding a test that empty lists do not warn. |
oscargus
force-pushed
the
incorrectdeprecationwarning
branch
from
506ea91
to
c0a384e
Compare
|
Smoke test added. |
QuLogic
approved these changes
Mar 30, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 30, 2022
QuLogic
added a commit
that referenced
this pull request
Mar 31, 2022
…719-on-v3.5.x Backport PR #22719 on branch v3.5.x (Fix incorrect deprecation warning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #22640
Simple fix based on @anntzer's suggestion. Seems to get rid of the deprecation warning if nothing else.
Makes sense to get it in for 3.5.2? (As it is caused by a change in 3.5 if I understand it correctly.)
Should I add a smoke test for it?
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).