Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix year offset not always being added #22871

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Fix year offset not always being added #22871

merged 1 commit into from
Apr 22, 2022

Conversation

oscargus
Copy link
Contributor

PR Summary

Closes #22472

image

Maybe this should go in 3.5.2 (previous related fix went in 3.5.1)? Marking as 3.5.2 for now.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus added this to the v3.5.2 milestone Apr 21, 2022
@oscargus oscargus changed the title Fix issue with date offset not always being added Fix date offset not always being added Apr 21, 2022
@oscargus oscargus changed the title Fix date offset not always being added Fix year offset not always being added Apr 21, 2022
@QuLogic QuLogic merged commit 2666b0d into main Apr 22, 2022
@QuLogic QuLogic deleted the fixdateoffset branch April 22, 2022 00:02
@QuLogic
Copy link
Member

QuLogic commented Apr 22, 2022

meeseeksdev backport to v3.5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ConciseDateFormatter not showing year anywhere when plotting <12 months
3 participants