Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify qt_compat, in particular post-removal of qt4 support. #23262

Merged
merged 1 commit into from Jun 13, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 13, 2022

Also note that None is never keyed off _ETS, which allows removing
the None: None entry have some more simplifications.
Also avoid the need for exception chaining suppression (raise ... from None).
Also clarify the error message when no qt binding can be imported
(the original motivation here; see #22673 (comment)).

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Also note that `None` is never keyed off `_ETS`, which allows removing
the `None: None` entry have some more simplifications.
Also avoid the need for exception chaining suppression (`raise ... from
None`).
Also clarify the error message when no qt binding can be imported.
@tacaswell tacaswell added this to the v3.6.0 milestone Jun 13, 2022
@tacaswell tacaswell merged commit 0371cf9 into matplotlib:main Jun 13, 2022
@anntzer anntzer deleted the qt4 branch June 13, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants