Fix PySide compatibility #2328
Fix PySide compatibility #2328
Conversation
|
My simple testing shows this works. However, I did not put it through a lot of rigorous testing. |
|
My simple testing also shows this works for both PySide and PyQt4. Two simple testings == one rigorous testing right? Joking aside, the issues are either not being able to import mpl at all or a dialog not opening, both of which pass here. I would argue any other issues should be a new issue anyway. If I have any say, this should be merged. |
|
OK... This fix (for PyQt4 v1 API) appears to break the ability to add/change the default text in the PySide PyQt4 v2 API. The image fails when the default text (labels) are changed, or additional text boxes are added. I haven't confirmed that it is this particular PR that causes it, but it's my strong suspicion. I'm working right now to track it down, but wanted to at least make a note that there are still problems. |
|
More on my last comment...it appears that issue I described only happens with LaTeX strings, and is not related to this PR. I'll continue to dig around and then file a separate issue and/or pull request. |
Fix PySide compatibility Conflicts: lib/matplotlib/backends/qt4_editor/formlayout.py
|
Backported to 1.3.x as c774379 |
|
@mdboom That commit appears to contain conflict markers. |
|
@dmcdougall: Thanks. I noticed that myself a few hours ago. I have since fixed it on 1.3.x. |
This uses PR #2326 from @pmarshwx, plus a fix for an AttributeError for QtCore.QString in PySide when opening the qt editor. This fixes issue #2318.
This works for me in PyQt4 API 1 and PySide, both on Python 2.7.3 in Linux. I've tested about as much of the functionality of the qt editor as I can think of, in both libraries, and I can't get it to break.