Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: correctly handle generic font families in svg text-as-text mode #23638

Merged
merged 3 commits into from
Sep 30, 2022
Merged

FIX: correctly handle generic font families in svg text-as-text mode #23638

merged 3 commits into from
Sep 30, 2022

Commits on Sep 30, 2022

  1. TST: add a test of font families in svg text-as-text mode 

    This tests:

1. all of the fonts from the generic lists Matplotlib maintains ends up in the
   svg
2. the generic family is included and un-escaped
3. the specific fonts are escaped
4. glyph fallback will happen in fonts found via generic family names
    @tacaswell @QuLogic
    tacaswell authored and QuLogic committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    a6f15f2 View commit details
    Browse the repository at this point in the history

  2. FIX: correctly handle generic font families in svg text-as-text mode 

    This:

- expands the generic fonts families to the user configured specific fonts
  in the svg output
- ensures that each font family only appears once per text element in the svg output
- ensures that generic families are unquoted and specific families are

closes matplotlib#22528
closes matplotlib#23492
    @tacaswell @QuLogic
    tacaswell authored and QuLogic committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    a0fcf79 View commit details
    Browse the repository at this point in the history

  3. FIX: do not raise in lru_cached function 

    If the cached function raises it will not be cached and we will continuously
pay for cache misses.
    @tacaswell @QuLogic
    tacaswell authored and QuLogic committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    6e99a52 View commit details
    Browse the repository at this point in the history