FIX: only expect FigureCanvas on backend module if using new style #23912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to un-break pycharm's backend_interagg Closes matplotlib#23911
anntzer
approved these changes
Sep 16, 2022
oscargus
approved these changes
Sep 17, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 17, 2022
…d module if using new style
|
Is this released? |
|
No, this will be in 3.6.1 when it is relesaed. |
Looking forward! |
QuLogic
added a commit
that referenced
this pull request
Sep 23, 2022
…912-on-v3.6.x Backport PR #23912 on branch v3.6.x (FIX: only expect FigureCanvas on backend module if using new style)
|
Thanks for moving so quickly on this @tacaswell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is to un-break pycharm's backend_interagg
Closes #23911
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).I'm not sure the best way to test this, I guess we need to make a minimal backend that does not have FigureCanvas and try push it through the machinery? Is it worth the effort?