Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor docstring typos #24282

Merged
merged 1 commit into from Nov 1, 2022
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 26, 2022

PR Summary

Found while testing out flake8-rst (for which there are unfortunately a few too many false positives.)

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

>>> fig.show()

>>> selector.add_state('square')
>>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>>

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspected the extra line was there to emphasize it, but I'm not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It starts a new box, so probably, yes. I'm more wondering about the rationale to put an empty command-line/return-press instead. Better to drop it completely then?

@ksunden ksunden added this to the v3.6.2 milestone Nov 1, 2022
@timhoffm timhoffm merged commit 14c50c8 into matplotlib:main Nov 1, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 1, 2022
tacaswell added a commit that referenced this pull request Nov 1, 2022
…282-on-v3.6.x

Backport PR #24282 on branch v3.6.x (Fix some minor docstring typos)
@QuLogic QuLogic deleted the docstring-typos branch November 1, 2022 22:23
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants