Remove unneeded _update_transScale calls in _init_axis. #24635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_init_axis is called only in the Axes constructor, where it is followed by a call to clear, which itself already calls _update_transScale (which is needed to take into account the axis scales that get set in it). So _init_axis doesn't need to call _update_transScale itself. Removing it avoids showcasing a private method in the custom_projection demo, and helps moving towards a system where updating an axis scale directly invalidates whatever is necessary (e.g. via a TransformWrapper) instead of requiring manual invalidation calls (i.e. _update_transScale).
PR Summary
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst