Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup cbook deprecations and layout #24923

Merged
merged 2 commits into from Jan 10, 2023
Merged

Cleanup cbook deprecations and layout #24923

merged 2 commits into from Jan 10, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 10, 2023

PR Summary

We previously had cbook in a subdirectory in order to better separate the deprecation machinery. But that has moved to _api, so this is now a single file, which we can move back to the top level.

Also, expire the deprecations in that file.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic
Flatten cbook into a single file
0cd7c30 
It was made a directory so that we could put deprecation machinery into
its own file, but that has now moved to the private `_api` module.
There's no need to put `cbook` code in its own directory now.
@QuLogic
Expire deprecations from cbook
6731a00
@QuLogic QuLogic added this to the v3.8.0 milestone Jan 10, 2023
oscargus
oscargus approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to green.

@anntzer anntzer merged commit 18f493a into matplotlib:main Jan 10, 2023
@anntzer anntzer mentioned this pull request Jan 10, 2023
Merged
6 tasks
@QuLogic QuLogic deleted the clean-cbook branch January 11, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@QuLogic @anntzer @timhoffm @oscargus