Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small unrelated cleanups/style fixes. #24929

Merged
merged 1 commit into from Jan 10, 2023
Merged

Small unrelated cleanups/style fixes. #24929

merged 1 commit into from Jan 10, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 10, 2023

  • Remove now-incorrect comment in cbook docstring (cbook now imports matplotlib at the top).
  • Simplify implementation of GrouperView, now that it doesn't forward deprecated methods to the inner grouper anymore. (followup to Cleanup cbook deprecations and layout #24923)
  • Minor tweak to BboxConnector init.
  • Axes3D doesn't need to call norm_angle (which just normalizes angles to -180..+180 degrees) before computing sin/cos.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
Small unrelated cleanups/style fixes.
6264d81 
- Remove now-incorrect comment in cbook docstring (cbook now imports
  matplotlib at the top).
- Simplify implementation of GrouperView, now that it doesn't forward
  deprecated methods to the inner grouper anymore.
- Minor tweak to BboxConnector init.
- Axes3D doesn't need to call norm_angle (which just normalizes angles
  to -180..+180 degrees) before computing sin/cos.
@anntzer anntzer added this to the v3.8.0 milestone Jan 10, 2023
@timhoffm timhoffm merged commit 038e805 into matplotlib:main Jan 10, 2023
@anntzer anntzer deleted the cs branch January 10, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anntzer @timhoffm @oscargus