Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support make_compound_path concatenating only empty paths. #25252

Merged
merged 1 commit into from Feb 20, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 18, 2023

Previously codes[i] would fail if codes (i.e. the concatenated path) had length zero.

Split out as preparatory work for #25247 (which introduces empty paths for contour levels that don't actually result in any level being drawn).

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Previously `codes[i]` would fail if codes (i.e. the concatenated path)
had length zero.
@jklymak jklymak merged commit f726d2c into matplotlib:main Feb 20, 2023
@anntzer anntzer deleted the ce branch February 20, 2023 22:25
@QuLogic QuLogic added this to the v3.8.0 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants