Restrict pyparsing version #26153
Merged
Restrict pyparsing version #26153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
the
Release critical
oscargus
force-pushed
the
pyparsing
branch
3 times, most recently
from
ccd8386
to
84af240
Compare
tacaswell
reviewed
Jun 20, 2023
| @@ -327,7 +327,7 @@ def make_release_tree(self, base_dir, files): | |||
| "numpy>=1.21", | |||
| "packaging>=20.0", | |||
| "pillow>=6.2.0", | |||
| "pyparsing>=2.3.1", | |||
There was a problem hiding this comment.
I do not think we should pin it here yet. The "happy paths" still work, it is the error messages that are broken.
tacaswell
reviewed
Jun 20, 2023
tacaswell
approved these changes
Jun 20, 2023
ksunden
approved these changes
Jun 20, 2023
|
Anyone can merge on green CI |
|
sigh, we apparently rely on setup.py's versions on azure. |
|
I'm going to force-push back to Oscar's last commit and then merge. |
|
I do not remember exactly which order I added these but most are required... |
|
I missed the force-pushing in the history, sorry 🐑 |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 20, 2023
|
Thank you @oscargus , sorry for needlessly delaying this. |
QuLogic
added a commit
that referenced
this pull request
Jun 20, 2023
…153-on-v3.7.x Backport PR #26153 on branch v3.7.x (Restrict pyparsing version)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The simple part of #26152
No documentation as I see this as a way to get the tests to pass again and hopefully it is fixed before next release.
PR checklist