Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort tex2uni data in mathtext #26193

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Sort tex2uni data in mathtext #26193

merged 1 commit into from
Sep 1, 2023

Conversation

devRD
Copy link
Contributor

@devRD devRD commented Jun 26, 2023

PR summary

Fixes #26029
Entries are converted to hex and the list is sorted on the LaTeX-strings

PR checklist

@devRD devRD marked this pull request as ready for review June 26, 2023 16:41
@oscargus
Copy link
Contributor

I wouldn't mind if #26173 and #26176 were merged first (there will be merge conflicts independent of order, but I hope that you have a script for this? Maybe that can be added as a comment in the file if it is short enough?).

@devRD
Copy link
Contributor Author

devRD commented Jun 27, 2023

Sure this can wait for merging. I did use a script, I will update the code with the comment.
We can refactor any other changes if needed.

@oscargus
Copy link
Contributor

I think that this can be updated now.

'triangle' : 9651,
'iiiint' : 10764,
'amalg' : 10815,
'merge' : 10837,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one fewer line in the new code, is something missing? (perhaps one of the things added by a recent PR?)

Copy link
Contributor

@oscargus oscargus Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! I think that there is a duplicate in the above list.

In current main len(tex2uni) is 632 which is 1107-476+1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it wasn't that hard to find...

    'nsqsubseteq'              : 8930,
    'nsqsupseteq'              : 8931,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...but isn't it different: nsqSUBseteq and nsqSUPseteq(?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the duplicate entry in main:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you right. I actually read it a few times...

@timhoffm timhoffm added this to the v3.8.0 milestone Sep 1, 2023
@timhoffm timhoffm merged commit 05e164b into matplotlib:main Sep 1, 2023
40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 1, 2023
QuLogic added a commit that referenced this pull request Sep 1, 2023
…193-on-v3.8.x

Backport PR #26193 on branch v3.8.x (Sort tex2uni data in mathtext)
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MNT]: Unify tex2uni
4 participants