Tweak shape repr in _api.check_shape error message. #26513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Aug 13, 2023
ksunden
reviewed
Aug 14, 2023
lib/matplotlib/_api/__init__.py
Outdated
| @@ -151,12 +151,10 @@ def check_shape(shape, /, **kwargs): | |||
| if (len(data_shape) != len(shape) | |||
| or any(s != t and t is not None for s, t in zip(data_shape, shape))): | |||
| dim_labels = iter(itertools.chain( | |||
| 'MNLIJKLH', | |||
| 'NMLIJKLH', | |||
There was a problem hiding this comment.
It's not new, but should L appear in this list twice? That seems odd/likely for unintended
Fill in "None" dims *from the end* with the letters N, M, L, K, ... so as to get e.g. "(N, 2)", "(M, 2, N)", "(L, M, N)", etc.
ksunden
approved these changes
Aug 15, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 15, 2023
QuLogic
added a commit
that referenced
this pull request
Aug 16, 2023
…513-on-v3.8.x Backport PR #26513 on branch v3.8.x (Tweak shape repr in _api.check_shape error message.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill in "None" dims from the end with the letters N, M, L, K, ... so as to get e.g. "(N, 2)", "(M, 2, N)", "(L, M, N)", etc.
PR summary
PR checklist