Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: codespace link in contribute index #26573

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

story645
Copy link
Member

@story645 story645 commented Aug 22, 2023

Following on from #26201, this adds a bullet link on the contribute landing page out to the set up part of the contributing guide. Also cleans up the styling in the new contributor section cause it feels really busy on mobile.

attn: @melissawm

@story645 story645 added the Documentation: devdocs files in doc/devel label Aug 22, 2023
@story645 story645 added this to the v3.8-doc milestone Aug 22, 2023

.. :octicon:`codespaces;1em;sd-text-info` placeholder for codespaces link
:octicon:`codespaces;1em;sd-text-info` :ref:`How do I start a pull request? <how-to-contribute>`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not attached to the focus on a PR given I used the pr icon in the last bullet, just can't think of anything else right now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I had misread - this looks good to me, we don't want it to be too long either. Maybe "How do I start a pull request on the browser?" if it fits...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the link goes to the local + codespace contribute instructions, which I think is fine b/c some contributors won't have the bandwidth to use codespaces. I think what I'm struggling w/ is differentiating that this is the nuts and bolts writing portion of the process rather than the exploratory find something to work on stage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good then, thanks!

@ksunden ksunden merged commit ffe9ac6 into matplotlib:main Aug 22, 2023
20 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 22, 2023
ksunden added a commit that referenced this pull request Aug 22, 2023
…573-on-v3.8.x

Backport PR #26573 on branch v3.8.x ([DOC]: codespace link in contribute index)
@QuLogic QuLogic modified the milestones: v3.8-doc, v3.8.0 Aug 28, 2023
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
@story645 story645 deleted the codespace-index branch October 6, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants