[MNT] Do not configure axes properties via subplots(..., subplot_kw={...}) #26635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While technical possible, this is an anti-pattern IMHO. We should keep Axes creation and customization separate. Extracted from matplotlib#14411.
timhoffm
force-pushed
the
reduce-subplot_kw
branch
from
22d0f16
to
23d101a
Compare
QuLogic
approved these changes
Aug 30, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 30, 2023
…via subplots(..., subplot_kw={...})
timhoffm
added a commit
that referenced
this pull request
Aug 30, 2023
…635-on-v3.8.x Backport PR #26635 on branch v3.8.x ([MNT] Do not configure axes properties via subplots(..., subplot_kw={...}))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technical possible, this is an anti-pattern IMHO. We should keep Axes creation and customization separate.
Extracted from the deferred #14411.